improve bridge discovery: fix bash bugs, expand builtins - #316
Merged
Conversation
Coverage Report for CI Build 29170030581Coverage remained the same at 0.0%Details
Uncovered Changes
Coverage Regressions3 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
rsteube
force-pushed
the
improve-bridge-detection
branch
from
June 16, 2026 21:33
43634f6 to
a373406
Compare
rsteube-bot
force-pushed
the
improve-bridge-detection
branch
from
July 11, 2026 21:53
a373406 to
fbe10e8
Compare
- Fix `os.Getenv("$PATH")` bug in bash completion location lookup (spurious `$` prefix)
- Reorder bashCompletionLocations to match canonical bash-completion _comp_load lookup order (user dirs → BASH_SOURCE → PATH → XDG_DATA_DIRS → legacy)
- Fix `for userDir := range strings.Split(...)` bug (was discarding value, using index as dir)
- Expand bash builtins from 45 to 81 entries (compgen -b; compgen -k) to include reserved keywords and missing builtins
- Remove unreliable `./completions` cwd-relative fallback
- Move legacy /etc/bash_completion.d paths to end of lookup order as fallbacks
Assisted-by: Crush:glm-5.2
rsteube-bot
force-pushed
the
improve-bridge-detection
branch
from
July 11, 2026 22:09
fbe10e8 to
8a18afb
Compare
rsteube-bot
marked this pull request as ready for review
July 11, 2026 22:09
rsteube
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.